Repository navigation
Separate GA and Pre-Release features for Nexus Messaging samples - #803
Merged
Merged
Conversation
atol
marked this pull request as ready for review
September 30, 2026 00:01
atol
force-pushed
the
alicelin/nexus-messaging-v2
branch
from
October 2, 2026 03:15
b9d1f88 to
7445a7d
Compare
Evanthx
requested changes
Oct 6, 2026
Evanthx
left a comment
Evanthx
left a comment
Contributor
There was a problem hiding this comment.
Minor changes, mostly to comments!
| .setWorkflowIdConflictPolicy( | ||
| WorkflowIdConflictPolicy.WORKFLOW_ID_CONFLICT_POLICY_USE_EXISTING) | ||
| .build()); | ||
| // Starts a new GreetingWorkflow with the caller-specified workflow ID. This is an async |
Contributor
There was a problem hiding this comment.
This says workflow ID, but we are passing a user ID. This is in the readme as well, so just needs to make sure that change is plumbed through.
Contributor
Author
There was a problem hiding this comment.
Yeah, I think we corrected this in the new sample, but I wanted to do a clean revert. I'll follow up with a separate PR.
| @@ -0,0 +1,19 @@ | |||
| This sample shows how to expose a long-running Workflow's queries, updates, and signals as Nexus operations. This | |||
| version uses the experimental `@TemporalOperation` annotation to declare Temporal-backed Nexus operations as ordinary | |||
| methods on `@ServiceImpl` classes instead of `@OperationImpl` factories that return `TemporalOperationHandler.create(...)`. | |||
Contributor
There was a problem hiding this comment.
It is using OperationHandler.sync and WorkflowRunOperation.fromWorkflowHandle instead of TemporalOperationHandler.create
Contributor
Author
There was a problem hiding this comment.
Ah, right. Thanks for the catch - will update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Separate GA and Pre-Release features for Nexus Messaging samples.
Please review by commit:
e344d6dupdating the original Nexus Messaging sample.Checklist
Closes: N/A
How was this tested: Ran samples locally
Any docs updates needed? No