Repository navigation
Conversation
docs.temporal.io's TypeScript "Set a Workflow's Task Queue" section used a hand-written sample that called Connection.create(), which doesn't exist (temporalio/documentation#5200). This snippet replaces it with compiled code.
2 tasks
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
snippets/src/start-workflow.tswith a newtypescript-start-workflowSnipsync marker. It connects withConnection.connect()using environment configuration and starts theexampleWorkflow on thesnippetsTask Queue, the same Task Queue the existingtypescript-worker-createsnippet polls.Why
The TypeScript "Set a Workflow's Task Queue" section on docs.temporal.io used a hand-written sample that called
Connection.create(), a method that has never existed onConnection(temporalio/documentation#5200). Hand-written samples aren't compiled anywhere, so sourcing this one fromsnippets/gets it type-checked by this repo'slint-format-buildjob.Companion docs PR: temporalio/documentation#5407 (draft until this merges).
Validation
Run locally in
snippets/:npm run build: passesnpm run lint: passesnpm run format:check: passesConnection.connect(...)changed back toConnection.create(),tsc --noEmitfails withTS2339: Property 'create' does not exist on type 'typeof Connection'. That's the error reported in the docs issue.