Repository navigation
Detect Nexus operation changes during replay - #1645
Merged
Merged
Conversation
Port the changes from #1405, originally contributed by JSap0914.
tconley1428
approved these changes
Oct 9, 2026
Sushisource
enabled auto-merge (squash)
October 9, 2026 21:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #1405
What
NexusOperationScheduledhistory events with the command produced during replayWhy
The Nexus operation state machine accepted scheduled history events without validating their service or operation. This allowed workflow code to change either field during replay without raising the non-determinism error used by comparable activity and child-workflow state machines.
Fixes #1231
Testing
cargo test -p temporalio-sdk-core nexus_operation_state_machine::tests --libcargo test -p temporalio-sdk-core --lib(367 passed, 1 ignored)cargo clippy -p temporalio-sdk-core --lib --tests --all-features -- -D warningscargo fmt --all --checkgit diff --check