Repository navigation
[Forwarder]: Remove allowlist check - #206
Merged
Merged
Conversation
Since #198 the gateway hands each accepted stream straight to the upstream's Forwarder.Handle, so nothing in the proxy dials the per-upstream socket any more. It was kept for local workers dialing it directly, but that is not a supported access path: workers only ever connect through the gateway, and the socket's path was a hash under the temp dir that nothing exposed. This removes the socket and everything that existed to serve it: internal/transport/socket, proxy.Server, and Dataplane.SocketPath. Start now opens the static upstream connections and binds the gateway. Stop drains only the gateway, so the concurrent per-upstream drain and its deadline arithmetic go with it.
The gateway's router.Handler rejects services outside the allowlist before routing, and with the per-upstream socket gone it is the forwarder's only caller, so the forwarder's own check can never fire. Forwarder no longer takes an allowlist.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Vaughan-Temporal
marked this pull request as ready for review
October 6, 2026 22:59
Vaughan-Temporal
changed the title
pseudomuto
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forwarder's allowlist check is redundant. With the per-upstream socket removed in #205, the gateway's router.Handler is the forwarder's only caller, and it already rejects services outside the allowlist before routing. This removes the check and the forwarder's allowlist dependency.