Skip to content

Name code generators after their generated artifacts - #12365

Closed
stephanos wants to merge 3 commits into
temporalio:mainfrom
stephanos:stephanos/rename-rpc-logtags-generator
Closed

stephanos wants to merge 3 commits into
temporalio:mainfrom
stephanos:stephanos/rename-rpc-logtags-generator

Conversation

@stephanos

@stephanos stephanos commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

What changed?

Rename internal generators to describe their generated artifacts and update build commands, directives, templates, and generated headers, with small lint fixes for the relocated tools.

Before After
genrpcwrappers genrpcclientwrappers
genroutingkeyextractor genrpcroutingkeyextractor
genrpcserverinterceptors genrpclogtagextractors
gendynamicconfig gendynamicconfigsettings
gensearchattributehelpers gensearchattributeeventaccessors
protogen genserverprotos
getproto exportapidescriptors

The new validation generator is renamed from genrpcvalidationinterceptor to genrpcvalidationdispatch in #12364.

Why?

Consistent names make each tool’s output clear and distinguish the local Server generator from upstream protogen.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Regeneration preserves all 22 generated Go bodies; descriptor export, generator and affected package tests (-tags test_dep), and make lint-code-fast pass.

Potential risks

External scripts invoking the renamed tool paths must update their commands.

@stephanos stephanos changed the title Rename RPC log-tag generator to genrpclogtags Name code generators after their generated artifacts Oct 2, 2026
@stephanos stephanos closed this Oct 2, 2026
@stephanos
stephanos deleted the stephanos/rename-rpc-logtags-generator branch October 5, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant