Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Rename internal generators to describe their generated artifacts and update build commands, directives, templates, and generated headers, with small lint fixes for the relocated tools.
genrpcwrappersgenrpcclientwrappersgenroutingkeyextractorgenrpcroutingkeyextractorgenrpcserverinterceptorsgenrpclogtagextractorsgendynamicconfiggendynamicconfigsettingsgensearchattributehelpersgensearchattributeeventaccessorsprotogengenserverprotosgetprotoexportapidescriptorsThe new validation generator is renamed from
genrpcvalidationinterceptortogenrpcvalidationdispatchin #12364.Why?
Consistent names make each tool’s output clear and distinguish the local Server generator from upstream
protogen.How did you test it?
Regeneration preserves all 22 generated Go bodies; descriptor export, generator and affected package tests (
-tags test_dep), andmake lint-code-fastpass.Potential risks
External scripts invoking the renamed tool paths must update their commands.