Repository navigation
Image cache lookup should support SHA256 digests and Image IDs #1406
Description
See #1391 (and this may be related to #699):
Testcontainers' image indexing code can't handle images that have SHA256 digests. We need a way to access the RepoDigests from docker-java's Image class. Unless I'm missing something, at the moment only RepoTags is mapped.
We would then modify RemoteDockerImage:
List<Image> updatedImages = listImagesCmd.exec();
updatedImages.stream()
.map(Image::getRepoTags)
.filter(Objects::nonNull)
.flatMap(Stream::of)
.map(DockerImageName::new)
.collect(Collectors.toCollection(() -> AVAILABLE_IMAGE_NAME_CACHE));
so that both Image::getRepoTags and Image::getRepoDigests are loaded into the cache. There's probably also some work to do around identity/equals/hashcode of DockerImageName objects in the cache.
EDIT 5 June 2020: We should also ensure that Image IDs are loaded into the cache - see #699.
Reacted by Benedikt Ritter, Johannes Bühler, Daniel Clausen, Tim Yates, Louis Jacomet, Benjamin Muskalla, l0rinc, Marc Philipp, Vaidotas Valuckas, Gary Hale and 1 more
Activity
Fix #1391 by using a tagged version of `sshd`
Fix #1391 by using a tagged version of `sshd` (#1407)
stale commentedon Jul 14, 2019
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.
stale commentedon Jul 28, 2019
This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case.
Workaround docker-java testcontainers#1406
[-]SHA256-versioned images cannot be used offline[/-][+]Image cache lookup should support SHA256 digests and Image IDs[/+]britter commentedon Jul 24, 2020
@rnorth we're still blocked by this from upgrading past 0.12.3. Any chance to get a fix for this?
bsideup commentedon Jul 24, 2020
@britter have you considered contributing a fix? You should have the most knowledge of the problem and how to fix it :)
britter commentedon Jul 27, 2020
@bsideup I had a look when I reported this initially and it was not clear to me how to fix this. I might have some time look at this again this week and come up with some more concrete questions.
Support SHA256 digest lookup in local image cache
Support SHA256 digests and Image IDs in local image cache lookup
Support SHA256 digests and Image IDs in image cache lookup
oualidbouh commentedon Sep 15, 2026
Hi! I’m interested in contributing to this issue. I
Is this issue still relevant with the current codebase? If so, I’d be happy to investigate it and work on a fix.