[aymenjamaaoui]

Kafka transactions need transaction.state.log.replication.factor and transaction.state.log.min.isr set to 1 on a single broker. Without them, initTransactions() times out while waiting for InitProducerId.

KafkaContainer and ConfluentKafkaContainer already set these values, but no test checks it. This PR adds a test for each class. The test commits a transaction and reads the message with a read_committed consumer.

Refs #1816

Summary by CodeRabbit

• Tests
  • Expanded Kafka container test coverage to verify that committed transactional messages are received by consumers configured to read committed records. The checks run against both Confluent Kafka and Apache Kafka containers.

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1a82e48c-b4d5-4480-a2ee-38d3f6facd8c

Commits

Reviewing files that changed from the base of the PR and between ea074e5 and 14c6182.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

No actionable comments were generated in the recent review.

Walkthrough

Adds a shared Kafka test that commits a record in a transaction and checks that a read_committed consumer receives it. The test runs against Confluent Kafka and Apache Kafka containers.

Changes: Kafka Transaction Test Coverage

Layer / File(s)	Summary
Shared transactional test modules/kafka/src/test/java/org/testcontainers/AbstractKafka.java	Creates a topic, sends and commits a record in a transaction, and asserts that a read_committed consumer receives exactly that record within 10 seconds.
Container implementation coverage modules/kafka/src/test/java/org/testcontainers/kafka/ConfluentKafkaContainerTest.java, modules/kafka/src/test/java/org/testcontainers/kafka/KafkaContainerTest.java	Adds tests that run the shared transactional test against Confluent Kafka 7.4.0 and apache/kafka-native:3.8.0.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: eddumelendez

Merge Risk: Minimal · previous review ea074

This change only adds tests for Kafka transactions on both container types and does not change production behavior. No merge-blocking risk was found.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: adding transaction tests for both Kafka container classes.
Description check	✅ Passed	The description explains the single-broker transaction issue, the tests being added, and the purpose of the change. It also references issue #1816.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Finishing Touches

Fix failing CI checks

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 96dfbafb-59b6-4685-a288-1711129cab31

📥 Commits

Reviewing files that changed from the base of the PR and between 8e54951 and ea074e5.

📒 Files selected for processing (3)

• modules/kafka/src/test/java/org/testcontainers/AbstractKafka.java
• modules/kafka/src/test/java/org/testcontainers/kafka/ConfluentKafkaContainerTest.java
• modules/kafka/src/test/java/org/testcontainers/kafka/KafkaContainerTest.java

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

[aymenjamaaoui]

Hi! This is my first PR in this repository, so the CI workflows are waiting for approval. Could a maintainer please approve them when you have time? Thank you!