Skip to content

Support pgsty/silo image in MinIO module - #12113

Merged
kiview merged 2 commits into
mainfrom
fix/minio-pgsty-image
Oct 17, 2026
Merged

kiview merged 2 commits into
mainfrom
fix/minio-pgsty-image

Conversation

@kiview

@kiview kiview commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

minio/minio has been removed from Docker Hub, and quay.io/minio/minio no longer allows anonymous pulls (401). MinIOContainerTest therefore fails on every build, including main.

This PR makes MinIOContainer accept pgsty/silo, the community-maintained MinIO fork (AGPL-3.0) from the Pigsty project. The tests and docs now use pgsty/silo:RELEASE.2026-09-16T00-00-00Z. This is the latest tag with a GitHub release, and its images are built in public CI with build attestations and SBOMs. The fork keeps MinIO's MINIO_* env vars, /minio/health/* endpoints, the server command and port 9000, so the container setup is unchanged.

DEFAULT_IMAGE_NAME stays minio/minio, so anyone using their own mirror of it keeps working.

Note that pgsty/silo is essentially maintained by a single person. Chainguard's fork was also considered: its free image only has a latest tag and failed a storage check during startup.

Summary by CodeRabbit

  • New Features
    • The MinIO container now supports the community-maintained pgsty/silo image as an alternative to minio/minio.
  • Documentation
    • Updated the MinIO module guide to explain the status of upstream MinIO builds and show pgsty/silo in examples.

This PR description was written and published by Claude (Opus 5.5) on behalf of @kiview.

minio/minio was removed from Docker Hub and quay.io no longer allows anonymous pulls, so the module's tests can no longer pull their image. Accept the community-maintained fork pgsty/silo (and its former name pgsty/minio) and use it in tests and docs.
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4a35c13d-bf94-41ea-a3da-864bce8d4205
📥 Commits

Reviewing files that changed from the base of the PR and between a72b021 and 2886371.

📒 Files selected for processing: 2
  • docs/modules/minio.md
  • modules/minio/src/main/java/org/testcontainers/containers/MinIOContainer.java
🚧 Files skipped from review as they are similar to previous changes: 1
  • docs/modules/minio.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The MinIO container now accepts pgsty/silo images alongside minio/minio. The tests use Silo, and the module documentation describes MinIO’s upstream status and identifies Silo as the image used in examples.

Changes: MinIO image compatibility

Layer / File(s) Summary
Image names, compatibility check, and validation
modules/minio/src/main/java/org/testcontainers/containers/MinIOContainer.java, modules/minio/src/test/java/org/testcontainers/containers/MinIOContainerTest.java, docs/modules/minio.md
The container’s compatibility check accepts minio/minio and pgsty/silo. The tests use pgsty/silo, and the documentation describes the upstream status and identifies Silo as the image used in examples.

Priority: ⬆️ High

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: eddumelendez

Merge Risk: ⚪ Minimal · up to 28863

The change documents and accepts Silo while retaining compatibility with minio/minio. The former pgsty/minio image is not a documented supported name, and no concrete merge-blocking issue is established; the PR appears ready after normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title is concise, specific, and accurately describes the main change: adding support for the pgsty/silo image in the MinIO module.
Description check Passed The description clearly explains the failing behavior, the proposed fix, compatibility details, test and documentation updates, and the rationale for selecting pgsty/silo.
Full details: Docstring Coverage

Explanation

Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 2
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kiview
kiview merged commit e16d3ea into main Oct 17, 2026
74 of 78 checks passed
@kiview
kiview deleted the fix/minio-pgsty-image branch October 17, 2026 18:32
@kiview kiview added this to the next milestone Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant