Repository navigation
Pass cause exception and fix error message in compose wait tests - #12149
siddiqueirshad wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Clarify wait-strategy failure messages core/src/test/java/org/testcontainers/junit/ComposeWaitStrategyTest.java, core/src/test/java/org/testcontainers/junit/DockerComposeWaitStrategyTest.java |
Updated failure messages for listening-port and multiple-strategy tests. The Docker Compose messages no longer include caught exception text. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Suggested reviewers: eddumelendez
Merge Risk: 
3a042
-
The changes improve wait-strategy test diagnostics without introducing production behavior risk.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Title check The title names the two changes in the PR: passing the caught exception as the cause to Assertions.fail, and fixing the error message in the compose wait tests. It is specific and matches the changese… Description check The description states the main change: passing the caught RuntimeException as the cause to Assertions.fail in ComposeWaitStrategyTest and DockerComposeWaitStrategyTest, and fixing the duplicated 'wit… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the two changes in the PR: passing the caught exception as the cause to Assertions.fail, and fixing the error message in the compose wait tests. It is specific and matches the changeset. The title does not name the duplicated 'with failed with' wording, but it covers the primary change.
Full details: Description check
-
Explanation
The description states the main change: passing the caught RuntimeException as the cause to Assertions.fail in ComposeWaitStrategyTest and DockerComposeWaitStrategyTest, and fixing the duplicated 'with failed with' text. It explains the purpose (preserving root cause stack traces). It does not use the template's sections, such as the contributing checklist or issue reference. The template's required parts are mostly guidance, and the description covers the 'describe the change and context' requirement, so the check passes.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 4 functions across 2 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Pass caught \RuntimeException\ as cause parameter to \Assertions.fail\ in \ComposeWaitStrategyTest\ and \DockerComposeWaitStrategyTest\ to preserve root cause stack traces, and correct duplicate 'with failed with' in failure message.
Summary by CodeRabbit