fix(meilisearch): add Meilisearch community module - #1113
Open
dmi03 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a community module for Meilisearch. There is no Python module yet,
although Java, Go and Rust have one.
Two things worth a look during review:
HttpWaitStrategyagainst/health, so the extra is declared asmeilisearch = []. The officialmeilisearchclient is only addedto the
testdependency group.productionmode by default, which makes amaster key mandatory. A random one is generated when none is given
and exposed via
get_master_key(). Keys shorter than 16 bytes arerejected in the constructor, since Meilisearch would otherwise refuse
to boot with a confusing error.