ci(rust): run the Rust test suite on Windows - #1178
Open
thekevinbot wants to merge 2 commits into
Open
thekevinbot wants to merge 2 commits into
thekevinbot wants to merge 2 commits into
Conversation
thekevinscott
enabled auto-merge
September 24, 2026 11:40
Gate the chmod-and-exec parser fixture to unix and let the unreadable-file helper report 'cannot enforce' off unix, which the tests already treat as a skip.
This was referenced Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1175
Adds a
Windows testsjob todirsql-rust-ci.yml: the Rust unit and integration suites (cargo test --features cli --tests --no-fail-fast) onwindows-latest.Also makes the integration suite compile on Windows:
path_table_on_file_e2e.rs(chmod + shebang parser fixture) is gated to unix like its siblings, andvtab.rs's unreadable-file helper reports "cannot enforce" off unix, which its tests already treat as a skip.Result: red, on real product bugs
The job runs and fails: 99 tests across 18 test binaries. The library and binary compile and most of the suite passes, but path handling is broken on Windows:
\, so config globs match nothing and path columns differ from Linux.C:\...) and~/path-table names are not recognized.{path}in JSON fixtures, read-onlyset_modified).This PR stays red until those land. Not bundled here, per the one-concern rule. The README support statement from #1175 waits on the fixes.
Run: https://github.com/thekevinscott/dirsql/actions/runs/35995035941