Repository navigation
chore: Say in the README that closing the client ends a write that the client has started to send with an OutcomeUnknownException. - #23
Merged
Conversation
…s sent with an OutcomeUnknownException. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QykegdHe7vhHMBN3kWxgfH
…e client has started to send with an OutcomeUnknownException. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QykegdHe7vhHMBN3kWxgfH
goloroden
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README said that closing the client ends every running request with a
CancellationException, and did not mention writes. A write that the client has started to send ends with anOutcomeUnknownExceptioninstead, whose cause is theCancellationException, even while the client is still connecting:close()aborts the running requests (Requests.java:213),receiveturns that into aCancellationException(Requests.java:155), andwritehands every failure after sending toOutcomes.ofWrite(Requests.java:117), which wraps whatever is neither a refusal nor a failed connection (Outcomes.java:49-58). The Javadoc ofClient.close()says so (Client.java:384-388), andCloseTestchecks it (CloseTest.java:100-103)."Closing the Client" and "Handling Errors" now say so, as the docs on eventfoundation.io do.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QykegdHe7vhHMBN3kWxgfH