Repository navigation
chore: Say how abortIn applies while a stream is read, and leave out setAccessible in the tests. - #186
Merged
Conversation
…e PHP 8.1 and is deprecated as of 8.5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CiuYmw4N6SSzfFyrwftUEj
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CiuYmw4N6SSzfFyrwftUEj
…for abortIn. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CiuYmw4N6SSzfFyrwftUEj
goloroden
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README now says how
abortInapplies while a stream is read. A request sent within the loop over a stream, such as a write for each observed event, is aborted through a second client, sinceabortInof the client that reads the stream applies to that stream. And a stream counts as being read as long as its iterator is kept, also once its loop was left withbreak, so anabortInmeant for the next request needs the iterator released first. The client cannot tell a loop that is left from one whose body runs, since the generator waits at the sameyieldin both; an abort time on the iterator or per call would have been new API for it.The tests no longer call
ReflectionProperty::setAccessible(), which has had no effect since PHP 8.1 and made the tests print deprecation notices on PHP 8.5.Closes #185
🤖 Generated with Claude Code
https://claude.ai/code/session_01CiuYmw4N6SSzfFyrwftUEj