Repository navigation
fix: Count store-failed as a refusal of a write, since the server sends it only for writes that it refuses before storing them. - #187
Merged
Conversation
…ds it only for writes that it refuses before storing them. The server reports store-failed once its store has failed before, for every later write that it refuses until it is restarted. A write during which storing fails gets an error without a code, a 500 or a stream without its end item, which stays an unknown outcome. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Svp844n6XkEuoe7y6zEFtF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Through the v2 API, a failed write counted as refused, so certainly not stored, if the server reported an error in the body of its answer, except for
store-failed, which counted as an unknown outcome. That exception was wrong: the server sendsstore-failedonly from its gatekeeper, which refuses every write before storing anything once its store has failed, until the database is restarted. The write during which storing actually fails gets the raw failure of the storage, which carries no code: a status 500 before the first heartbeat, or a stream without its terminal item after it. Both stay an unknown outcome.So every error in the body now counts as a refusal,
ErrorCode::STORE_FAILEDincluded, for writing events and for registering an event schema. The statuses, the v1 rules, and a stream that ends without its terminal item stay as they were. The tests expectstore-failedto throw theDbApiExceptionitself.QA is green against
latestandpreview.🤖 Generated with Claude Code
https://claude.ai/code/session_01Svp844n6XkEuoe7y6zEFtF