Skip to content

Binder gaps left by the notebook E2E (#26) #172

Closed

Description

@b-re-w

From ksp-fixtures/notebook-e2e README 'Gaps' and pythonx-compose's review (2026-10-04). Each becomes its own issue in its turn.

Activity

  1. b-re-w commented on Oct 25, 2026

    @b-re-w
    MemberAuthor

    Split: #307 (shape/colors), #308 (Card modifier proxy argument), #309 (colour-scheme factories). The CI and AWT IME items are left out for now, per the coordinator.

  2. b-re-w commented on Nov 12, 2026

    @b-re-w
    MemberAuthor

    Status 2026-11-13: the first item is done. desktop.yml runs :python-multiplatform-compose:fixtures:notebook-e2e:desktopTest against a pythonx-compose wheel built in the job, and also runs it in a native image; both jobs passed on develop in run 42402779142. #307, #308 and #309 are closed. The only item left is the AWT IME decoding layer, which the coordinator left out earlier. This issue stays open for it.

  3. b-re-w commented on Nov 19, 2026

    @b-re-w
    MemberAuthor

    Status audit (2026-11-19)

    # Item Status Landed via Current state / remaining
    1 Run :python-multiplatform-compose:fixtures:notebook-e2e in CI Done #213 (desktop.yml notebook-e2e), #249 / #251 (notebook-e2e-native-image) Runs in CI against the built pythonx-compose wheel on both the JVM (desktopTest, 20/20) and GraalVM native-image (notebookE2eNativeRun, 20/20, no libjvm).
    2 Button / Card shape= and colors= (foundation.shape, ButtonDefaults.buttonColors) Done #307 / PR #314 (object @Composable members bound via instance thunk; androidx.compose.foundation.shape walked; ShapeAndColorsRenderTest) RoundedCornerShape, ButtonDefaults.button_colors(...), and CardDefaults.card_colors(...) bind, render, and type-check in .pyi stubs (pythonx-compose #148 / #149).
    3 Card(modifier=Modifier): a proxy class passed as an argument Done #308 / PR #312 (OBJECT slot accepts a proxy class via register_empty), #322 / #324 (Modifier.Companion value binding and register_empty(cls, callable)), pythonx-compose #134 / #136, #138 / #139 Card(modifier=Modifier) and Modifier.padding(16) work out of the box without host-side setup.
    4 Colour-scheme factories blocked by the default-omission cap (MAX_OMITTABLE_PARAMETERS = 6) Done #309 / PR #315 (ColorScheme 48-argument constructor and copy() bound), pythonx-compose #135 / PR #137 (light_color_scheme and dark_color_scheme fill 48 Material 3 defaults with surface_tint = primary and call ColorScheme(...)) light_color_scheme(primary=...) and dark_color_scheme(...) work at run time and pass mypy stub checks.
    5 AWT IME decoding layer (InputMethodEvent to commitText / setComposingText) Open (deferred) None (deferred per coordinator decision) InputMethodScene.kt verifies IME composition offscreen via CanvasLayersComposeScene and PlatformTextInputMethodRequest.editText; the top-level AWT window layer decoding java.awt.event.InputMethodEvent requires a real OS window and stays deferred.
  4. b-re-w commented on Nov 21, 2026

    @b-re-w
    MemberAuthor

    Leader audit 2026-11-21: items 1-4 are done on develop (evidence in the ticked lines). Item 5 (AWT IME decoding layer) stays open: it needs a real OS window and is not walker work.

  5. b-re-w commented on Nov 21, 2026

    @b-re-w
    MemberAuthor

    Items 1-4 done (leader audit 2026-11-21, evidence in the ticked lines). Item 5 (AWT IME decoding layer) merged into #191 with its criterion. Source: leader answer 2026-11-21 18:00 (team report pmp-binder.md, "## Leader answer", item 3).

  6. b-re-w commented on Nov 21, 2026

    @b-re-w
    MemberAuthor

    Item 5 (the AWT IME decoding layer) stays in 1.0; it is tracked in #191, which is now in 1.0 in full. Source: owner decision 2026-11-21 21:55, via the leader (team report pmp-binder.md, "## Owner decision (2026-11-21 21:55): no "after 1.0" moves by the leader"): "일을 제대로 하면 될거를 쓸데없이 자꾸 미루려고만 하네? 191, 443, 175 전부 1.0에 넣어". Owner rule 2026-11-21 22:05: scope is never reduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions