Track entries in collections with a custom entry class - #45
Merged
Merged
Conversation
Contributor
|
Cool, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entries in collections with a custom
entry_classare never tracked. Saving one invalidates nothing and the pages rendering it stay stale. The reason is the exact class being hooked: the augmentation hook is filed underEntryand looked up under e.g.ProductEntry, so it never fires.The fix registers the hook on every entry class in existence. Reusing the closure is safe since
runHooks()rebinds per call. Entries are the only affected case, so the other hooks are unchanged.Added tests that fail on main and pass here.