Skip to content

ci(workflows): replace dispatch PAT with GitHub App tokens - #790

Merged
tobiasehlert merged 2 commits into
mainfrom
api-go-app-tokens
Oct 19, 2026
Merged

tobiasehlert merged 2 commits into
mainfrom
api-go-app-tokens

Conversation

@tobiasehlert

Copy link
Copy Markdown
Member

Summary

  • Replace all three REPO_ACCESS_TOKEN consumers with short-lived tibiadata-ci installation tokens: documentation dispatch to tibiadata-api-docs, and build dispatches to tibiadata-argocd-app-of-apps and tibiadata-helm-charts.
  • Pin actions/create-github-app-token to verified stable release v3.3.0 (64ab729a6294000f5aa4a4bc0b73d1f32bc45510), explicitly scope each token to its single destination under owner tibiadata, and request only Contents: write. Default post-job revocation remains enabled.
  • Preserve repository_dispatch actions, event names, payloads, triggers, job conditions, and unrelated GITHUB_TOKEN uses. Document CI authentication prerequisites in README.

Validation

  • go run github.com/rhysd/actionlint/cmd/actionlint@latest -shellcheck= .github/workflows/build.yml .github/workflows/documentation.yml (resolved v1.7.12): passed.
  • Parsed both workflows and compared them to HEAD before migration after removing token-creation steps and restoring legacy token references: otherwise structurally identical. Asserted exact credentials, owner, destination scopes, permission, verified SHA and token wiring for each dispatch.
  • git diff --check: passed. Repository-wide search found no remaining legacy token references.
  • Read-only metadata confirms the organization variable TIBIADATA_CI_CLIENT_ID and secret TIBIADATA_CI_PRIVATE_KEY are available to this repository; public app metadata confirms Contents: write.
  • No release, deployment, repository dispatch, or live token minting was executed. Destination installation coverage and actual credential validity remain runtime prerequisites; no organization settings were changed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@tobiasehlert tobiasehlert added documentation Improvements or additions to documentation github_actions Pull requests that update Github_actions code labels Oct 19, 2026
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.87%. Comparing base (561a40a) to head (80a7f24).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #790   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files          24       24           
  Lines        3064     3064           
=======================================
  Hits         2723     2723           
  Misses        341      341           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tobiasehlert tobiasehlert self-assigned this Oct 19, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

@tobiasehlert
tobiasehlert merged commit 6fe7388 into main Oct 19, 2026
8 checks passed
@tobiasehlert
tobiasehlert deleted the api-go-app-tokens branch October 19, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation github_actions Pull requests that update Github_actions code

Development

Successfully merging this pull request may close these issues.

1 participant