Repository navigation
fix(character): use Berlin date for house payments - #795
Open
tobiasehlert wants to merge 2 commits into
Open
tobiasehlert wants to merge 2 commits into
tobiasehlert wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 25 25
Lines 3173 3173
=======================================
Hits 2814 2814
Misses 359 359 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
House payment dates are calendar dates displayed in Tibia's Europe/Berlin timezone. Formatting the Fansite API's
paidUntiltimestamp as a UTC date can therefore produce the previous day around local midnight.Format house payment dates in Europe/Berlin and add regression coverage for a timestamp that crosses the UTC date boundary. Other timestamp fields remain unchanged.
Tests:
go test ./... -count=1Fixes: #793