Conversation
8 of 9 tasks
dehanj
force-pushed
the
add_reset
branch
2 times, most recently
from
September 16, 2026 13:09
c2db61a to
31eee41
Compare
dehanj
marked this pull request as ready for review
September 16, 2026 13:29
Support resetting a TKey before loading an app, given that the TKey supports it and an app is already loaded. If the app or the TKey does not support a reset, a manual re-plug is still needed. tkey-runapp tries to detect the capabilties of a tkey, but when using a non usb device, such as a tty with QEmu it needs some help. Use the flags `--not-usb-device` and/or `-no-remote-close` to convey the capabilities. Updates tkeyclient to pre-released version for the new reset, reconnect, and error types.
Gives a slighlt higher value 33, than the limit. Turn off for now, refactor later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated tkey-runapp to use newer tkeyclient in order to test the new reset command, see tillitis/tkeyclient#31
Feature description:
Support resetting a TKey before loading the app, given that the TKey supports it and an app is already loaded.
If the app or the TKey does not support a reset, a manual re-plug is still needed.
Updates tkeyclient to pre-released version for the new reset, reconnect, and error types
I think this should supersede #31.
Compared to that PR this is lacking a separate sub-command/flag to perform just a reset while not loading an app. It would need to support choosing which reset type, and a way to input nextAppData. I purpose that we add that in a later PR.
testapp-probei tkey-boot-verifier that has that specific functionality.Type of change
Submission checklist
QEMU is updated to reflect changes