Skip to content

a bunch of small fixes (dw most of the diff is cargo lock) - #66

Merged
timothebot merged 4 commits into
timothebot:mainfrom
pheenty:fixes
May 8, 2026
Merged

timothebot merged 4 commits into
timothebot:mainfrom
pheenty:fixes

Conversation

@pheenty

@pheenty pheenty commented Apr 26, 2026 •

Copy link
Copy Markdown
Contributor

those are literal one-liners, too lazy to split them into PRs

most importantly, fixed nu template (and part of prompt.rs not working with symlinks correctly. also removed unnecessary path exists, path type already checks for that and returns null if it does not.

also:
Cargo.toml -> release builds are now stripped, not reason for them to not be, and deps don't pull their unused default features anymore. crates compiling 53 -> 44, total binary size 1264 -> 1048 kb (linux x86_64). also ran cargo update.

Readme.md and docs -> added info about nushell hack to set --cmd=cd

commands.rs -> lacy help init post-help message is now a raw string, no more \"eval \\\"\\$(lacy init bash)\\\"\" (actual war crime)

tests -> added test_dots() to test (/home/pheenty/git/lacy) $ y .. other -> /home/pheenty/git/other_project

globally (mostly prompt.rs and query_part.rs) -> killed a bunch of non-idiomatic (or straight up idiotic) code 🥹, thanks cargo clippy -- -W clippy::pedantic). no architecture changed, just local parts of code, so should be straightforward enough.

all tests pass, clippy is happy, ran cargo fmt, nothing seems to be broken etc etc

@pheenty
pheenty requested a review from timothebot as a code owner April 26, 2026 03:09
@pheenty
pheenty force-pushed the fixes branch 2 times, most recently from 7aab688 to 39e08b2 Compare April 26, 2026 06:40
@pheenty
pheenty marked this pull request as draft April 26, 2026 06:45
@pheenty
pheenty marked this pull request as ready for review April 26, 2026 07:42
@pheenty pheenty changed the title a bunch of small fixes a bunch of small fixes (dw most of the diff is cargo lock) Apr 26, 2026
Comment thread templates/nu.nu Outdated
Comment thread docs/src/setup.md
@pheenty

pheenty commented May 6, 2026 •

Copy link
Copy Markdown
Contributor Author

hm, macos is being schizo about the tests

@pheenty
pheenty requested a review from timothebot May 6, 2026 11:36
@pheenty

pheenty commented May 7, 2026 •

Copy link
Copy Markdown
Contributor Author

oh forgot fmt after the latest fix
anyway DNM for now, found another bug i might've introduced
nevermind, i didn't have my latest commit installed on the laptop

@timothebot

Copy link
Copy Markdown
Owner

thanks ted

@timothebot
timothebot merged commit c31ff8a into timothebot:main May 8, 2026
5 checks passed
@pheenty
pheenty deleted the fixes branch May 8, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants