a bunch of small fixes (dw most of the diff is cargo lock) - #66
Merged
Merged
Conversation
pheenty
force-pushed
the
fixes
branch
2 times, most recently
from
April 26, 2026 06:40
7aab688 to
39e08b2
Compare
pheenty
marked this pull request as draft
April 26, 2026 06:45
pheenty
marked this pull request as ready for review
April 26, 2026 07:42
pheenty
commented
Apr 29, 2026
timothebot
requested changes
May 4, 2026
Contributor
Author
|
hm, macos is being schizo about the tests |
Contributor
Author
|
oh forgot |
timothebot
approved these changes
May 8, 2026
Owner
|
thanks ted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
those are literal one-liners, too lazy to split them into PRs
most importantly, fixed nu template (and part of
prompt.rsnot working with symlinks correctly. also removed unnecessary path exists, path type already checks for that and returns null if it does not.also:
Cargo.toml-> release builds are now stripped, not reason for them to not be, and deps don't pull their unused default features anymore. crates compiling 53 -> 44, total binary size 1264 -> 1048 kb (linux x86_64). also rancargo update.Readme.mdand docs -> added info about nushell hack to set --cmd=cdcommands.rs-> lacy help init post-help message is now a raw string, no more\"eval \\\"\\$(lacy init bash)\\\"\"(actual war crime)tests -> added
test_dots()to test(/home/pheenty/git/lacy) $ y .. other->/home/pheenty/git/other_projectglobally (mostly
prompt.rsandquery_part.rs) -> killed a bunch of non-idiomatic (or straight up idiotic) code 🥹, thankscargo clippy -- -W clippy::pedantic). no architecture changed, just local parts of code, so should be straightforward enough.all tests pass, clippy is happy, ran cargo fmt, nothing seems to be broken etc etc