Adding encoding specification parameter when opening yaml file - #86
Merged
Merged
Conversation
Adding the ability to specify in which encoding the file should be opened to generate a table from yaml
Owner
|
Hee, thanks for the PR! This could be an interesting addition. We should also add it to There's still a unit test to check though. |
timvink
requested changes
Aug 6, 2025
Comment on lines
+137
to
+139
| if "encoding" in kwargs: | ||
| defaultEncoding = kwargs["encoding"] | ||
| del kwargs["encoding"] |
Owner
There was a problem hiding this comment.
Let's move this below the json_kwargs line. If pd.json_normalize() ever adds an encoding parameter, we would still be able to processs it.
Even better would be to just use: with open(args[0], "r", encoding=kwargs.get("encoding","UTF-8") as f:
Comment on lines
+147
to
+150
| defaultEncoding = "UTF-8" | ||
| if "encoding" in kwargs: | ||
| defaultEncoding = kwargs["encoding"] | ||
| del kwargs["encoding"] |
Owner
There was a problem hiding this comment.
Same, just use encoding=kwargs.get("encoding","UTF-8") directly.
Simplify the encoding handling, add it to read_raw() as well, document it and add a test with cp1251 encoded files. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JCJnK1rDt8rmDsXTFc7AHE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the ability to specify in which encoding the file should be opened to generate a table from yaml