[MrBeldum]

Summary

Sibling to #275.

CreateContext asserted partition keys with pk.(string), and UpdateContext did the same for id and pk after merging. A non-string value (for example a numeric id from JSON) panicked instead of returning an error.

Validate with nonEmptyString before touching the client on create, and before ReplaceItem on update — the same approach as the DeleteContext id guard.

Test plan

• go test ./storage/ -run 'TestNonEmptyString|TestCosmosDBCreateContextRejects'

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 779680b6-f058-42c8-b3d7-1e5b1e944ba3

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Lutherwaves]

praise: Closes the Create/Update follow-up from #275, and the new tests fail on the old code.

suggestion (non-blocking): Whichever of #275/#276 merges second could switch DeleteContext to nonEmptyString too, so all three methods share one check and one error wording.

[Lutherwaves]

Thanks for your contribution!

[MrBeldum]

Addressed in 75817ac — verified just now:

• gofmt: removed the extra blank line; gofmt -l is clean on the changed files.
• Unused cosmosStringSample: removed (was staticcheck U1000).
• Partition-key wording: reworded to "This adapter only builds string partition keys and item ids."
• Shadowed-variable branch: deduped to a single lookup + one nonEmptyString check.
• Notes-to-self lines in the test: removed.

One item left as the reviewer framed it: switching DeleteContext to nonEmptyString is deferred to whichever of #275/#276 merges second, to avoid a cross-PR dependency (this branch defines the helper; #275 owns the DeleteContext validation).

Validation: go test ./storage/ -run 'TestNonEmptyString|TestCosmosDB' passes; go vet ./storage/ clean.

These changes were prepared with AI assistance and validated by running the package tests; not personally reviewed/tested by Daniel.

[MrBeldum]

Resolved the merge conflict with upstream main (merge commit 104c45e). The conflict was in UpdateContext: kept this PR's validated idStr/pkStr (no bare type assertions) and kept upstream's session-token recording from ReplaceItem. Full storage test suite passes locally; CI is the gate for the new head.

Disclosure: this conflict resolution was assisted by AI, reviewed against the PR's intent before pushing.