fix: Keep the JSON content type when a response carries another header. - #66
Merged
Merged
Conversation
The default was applied only when no header was passed at all, so a response built with a Link or a Cache-Control header lost it and PHP fell back to its own text/html default. The pagination example in the README produced JSON labelled as text/html. The default is now a base that supplied headers add to, and a supplied content type still replaces it rather than appending a second value.
The workflow installed its own PHP through setup-php, so CI and a developer could run different runtimes with nothing to reveal the drift. It now reads the image from make show-image, which leaves the Makefile as the single declaration of what PHP runs on, derived from the version in composer.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What this pull request does.
Related issue
Closes #...
Checklist
composer reviewpasses.composer testspasses.