Skip to content

opts tidy is a bug? #51

Closed
Closed

Description

@ChunMengLu

var tidy = this.key;

function Limiter(opts) {
  this.id = opts.id;
  this.db = opts.db;
  this.tidy = opts.tidy || false;
  // ... ...
}

emmm,but tidy = this.key !

Limiter.prototype.get = function (fn) {
  var db = this.db;
  var tidy = this.key;
  var duration = this.duration;
  // ... ...
}

Activity

  1. noamshemesh commented on Aug 7, 2019

    @noamshemesh
    Collaborator

    you are right, that means that tidy was always true until now.
    I will release a version soon without the ability to set tidy (what will make it always true) and will remove this from the documentation for now.
    Thanks

  2. nivek3 commented on Aug 15, 2019

    @nivek3
    Contributor

    I‘m sorry for making such a mistake.
    now, the tidy always true, I will fix it as soon as possiable.

  3. noamshemesh commented on Aug 15, 2019

    @noamshemesh
    Collaborator

    Thanks @penghap

    No need to submit a PR, this is a minor issue that I will fix soon.

  4. added 3 commits that reference this issue on Aug 16, 2019
    8cc9c80
    d289aa6
    b958870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions