docs(policies): document address comparison case sensitivity - #756
Draft
andrewkmin wants to merge 2 commits into
Draft
docs(policies): document address comparison case sensitivity#756andrewkmin wants to merge 2 commits into
andrewkmin wants to merge 2 commits into
Conversation
`wallet_account.address` is compared exactly, including case, while `eth.tx.to` / `eth.tx.from` and several other transaction fields are compared case-insensitively. Turnkey stores EVM wallet account addresses in EIP-55 checksummed form, so a condition written with an all-lowercase EVM address silently never matches — it stops granting on an EFFECT_ALLOW policy, and stops blocking on an EFFECT_DENY policy. Nothing in the docs said so, and the EIP-712 guidance actively pointed the other way: it told readers to make all hex-encoded strings lowercase. That advice is correct for `eth.eip_712` and `eth.tx` fields and wrong for `wallet_account.address`, so it is now explicitly scoped. Adds a Case sensitivity section covering the exhaustive list of case-insensitive fields, the stored casing of each address format, and the reason base58 and base64url addresses (Solana, Tron, Dogecoin, XRP, Bitcoin P2PKH/P2SH, TON) are compared case-sensitively — for those encodings, two strings differing only in case are two different addresses. Also documents `CaseInsensitiveString()`, which had no coverage anywhere in the docs despite being available in the grammar. It is documented in the wrap-both-sides form, which behaves identically before and after the engine change in tkhq/mono, so this page does not depend on that landing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wallet_account.addressis compared exactly, including case, whileeth.tx.to/eth.tx.fromand several other transaction fields are compared case-insensitively. Turnkey stores EVM wallet account addresses in EIP-55 checksummed form, so a condition written with an all-lowercase EVM address silently never matches — it stops granting on an EFFECT_ALLOW policy, and stops blocking on an EFFECT_DENY policy.Nothing in the docs said so, and the EIP-712 guidance actively pointed the other way: it told readers to make all hex-encoded strings lowercase. That advice is correct for
eth.eip_712andeth.txfields and wrong forwallet_account.address, so it is now explicitly scoped.Adds a Case sensitivity section covering the exhaustive list of case-insensitive fields, the stored casing of each address format, and the reason base58 and base64url addresses (Solana, Tron, Dogecoin, XRP, Bitcoin P2PKH/P2SH, TON) are compared case-sensitively — for those encodings, two strings differing only in case are two different addresses.
Also documents
CaseInsensitiveString(), which had no coverage anywhere in the docs despite being available in the grammar. It is documented in the wrap-both-sides form, which behaves identically before and after the engine change in tkhq/mono, so this page does not depend on that landing.