Repository navigation
Docs: keep .cache out of both publishing recipes - #116
Merged
Merged
Conversation
<out>/.cache/ holds --cache-right's HAR recordings, with cookies, auth headers and response bodies. wrangler pages deploy uploads it publicly (it has no exclude), and the reports-repo cp -R commits it to history. Both recipes now remove it first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #104
Problem
The publishing recipes in
docs/output.md#markdownuploaded the whole out dir,<out>/.cache/included. That directory holds--cache-right's Playwright HAR recordings, with cookies,Authorizationheaders and response bodies (signed-in pages too, viastorageState.right).wrangler pages deployhas no exclude flag, so the HARs were publicly readable atpr-123.<p>.pages.dev/.cache/...unless Access is on.cp -R renderdiff-out/.committed them to the repo's history.Change
<out>/.cache/.rm -rf renderdiff-out/.cachebefore the deploy. This drops the replay cache, so the next--cache-rightrun loads live.rm -rf reports/pr-123/.cacheafter the copy.The GitHub Action is unaffected:
actions/upload-artifact@v4skips hidden files by default.Not in this PR
renderdiff publish(step 2 of #104) is deferred. Steps 1 and 3 are shipped, andpublishmostly saves typing over the documented recipe. It should be built together with the action'spublish-repoinput and smaller reports (#113, the WebP and tiling bullet).🤖 Generated with Claude Code