Repository navigation
probe: refuse run-only flags, pick the storage state by side, name the width - #123
Merged
Merged
Conversation
…e width probe takes an allow-list of the flags it uses; any other flag (--dry-run, --out, --sitemap, --threshold, --accept, --left-/--right-storage-state, ...) exits 2 instead of being ignored. It uses the storage state of the config side whose origin the URL is on (else right's if set, else left's) and prints it, and prints the width it falls back to without --width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renderdiff probetakes an allow-list of the flags it uses (--config,--left,--width,--loads,--concurrency,--mask,--hide,--mask-media,--no-freeze-video,--storage-state,--help,--version). Any other flag exits 2 withprobe does not take <flag>.<right><route>.Storage state: <path> (<side>)). Without--width, it prints the width it uses:Width: 1440 (first of …; --width <n> for another).Behaviour change: flags probe used to ignore now exit 2. Examples are
--dry-run(which used to start a browser anyway),--out,--threshold,--computedand--left-/--right-storage-state.Testing
tests/unit/cli-args.test.ts:--dry-run,--out=xand--left-storage-stateare refused.--widthis given.npm run typecheck,npm run lint,npm run format:checkandnpm testpass (391/391). The visual suite was not run.🤖 Generated with Claude Code