Skip to content

probe: refuse run-only flags, pick the storage state by side, name the width - #123

Merged
tmashara merged 1 commit into
mainfrom
claude/probe-flags
Nov 2, 2026
Merged

tmashara merged 1 commit into
mainfrom
claude/probe-flags

Conversation

@tmashara

@tmashara tmashara commented Nov 2, 2026

Copy link
Copy Markdown
Owner
  • renderdiff probe takes an allow-list of the flags it uses (--config, --left, --width, --loads, --concurrency, --mask, --hide, --mask-media, --no-freeze-video, --storage-state, --help, --version). Any other flag exits 2 with probe does not take <flag>.
  • It uses the storage state of the config side whose origin the URL is on. If the URL is on neither side, it uses the right side's state if one is set, then the left side's. Before this, probe always used the left side's state, even though SKILL.md says to probe <right><route>.
  • It prints the storage state it chose (Storage state: <path> (<side>)). Without --width, it prints the width it uses: Width: 1440 (first of …; --width <n> for another).

Behaviour change: flags probe used to ignore now exit 2. Examples are --dry-run (which used to start a browser anyway), --out, --threshold, --computed and --left-/--right-storage-state.

Testing

  • New unit tests in tests/unit/cli-args.test.ts:
    • --dry-run, --out=x and --left-storage-state are refused.
    • The fallback width line is printed, and is absent when --width is given.
    • The storage-state side is picked for a left URL, a right URL, a URL on neither side, and a URL on neither side when only the left side has a state.
  • npm run typecheck, npm run lint, npm run format:check and npm test pass (391/391). The visual suite was not run.

🤖 Generated with Claude Code

…e width

probe takes an allow-list of the flags it uses; any other flag (--dry-run, --out, --sitemap, --threshold, --accept, --left-/--right-storage-state, ...) exits 2 instead of being ignored. It uses the storage state of the config side whose origin the URL is on (else right's if set, else left's) and prints it, and prints the width it falls back to without --width.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tmashara
tmashara merged commit b52d5c4 into main Nov 2, 2026
3 checks passed
@tmashara tmashara mentioned this pull request Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant