Skip to content

fix: stop Python publications when their ASGI listener exits - #190

Merged
0xcadams merged 4 commits into
0xcadams/python-platform-wheelsfrom
0xcadams/python-asgi-lifecycle
Oct 10, 2026
Merged

0xcadams merged 4 commits into
0xcadams/python-platform-wheelsfrom
0xcadams/python-asgi-lifecycle

Conversation

@0xcadams

@0xcadams 0xcadams commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

What

Continue the Python wheel stack after #189: ensure ad-hoc URLs stop serving when their local ASGI listener exits unexpectedly, and verify the installed platform wheel can run a real local ASGI lifecycle.

Why

The Python SDK previously kept a ready URL registered after the listener had stopped, until the caller left the context manager. The wheel release check verified its binary and metadata but did not run a packaged ASGI app, and pull-request CI did not run Python checks or wheel packaging. Linux CI also exposed GoReleaser's valid seven-character snapshot IDs.

Changes

  • Detect a stopped ASGI server, unregister its publisher before reporting a listener failure, and retry cleanup on close if necessary.
  • Cover listener loss in the Python SDK tests.
  • Run an installed-wheel ASGI startup, streaming HTTP, WebSocket, and shutdown smoke in platform wheel verification.
  • Check the Python SDK and all platform wheels in CI, including seven-character GoReleaser snapshot IDs.

@0xcadams
0xcadams force-pushed the 0xcadams/python-asgi-lifecycle branch from ea58e3c to 5c5d41a Compare October 10, 2026 07:48
@0xcadams
0xcadams force-pushed the 0xcadams/python-asgi-lifecycle branch from 5c5d41a to 380ae58 Compare October 10, 2026 07:52
@0xcadams
0xcadams force-pushed the 0xcadams/python-asgi-lifecycle branch from 380ae58 to e3cb29d Compare October 10, 2026 21:45
@0xcadams
0xcadams force-pushed the 0xcadams/python-asgi-lifecycle branch from e3cb29d to cf0fef2 Compare October 10, 2026 21:54
@0xcadams
0xcadams added this pull request to stack #164 October 10, 2026 21:55
@0xcadams
0xcadams force-pushed the 0xcadams/python-asgi-lifecycle branch from cf0fef2 to bc3e5d6 Compare October 10, 2026 21:57
@0xcadams
0xcadams merged commit 005b17f into main Oct 10, 2026
25 of 27 checks passed
@0xcadams
0xcadams deleted the 0xcadams/python-asgi-lifecycle branch October 10, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant