Skip to content

test: retain exact workload HTTP denial evidence #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0xcadams wants to merge 1 commit into from
Closed

test: retain exact workload HTTP denial evidence #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 31 additions & 8 deletions internal/daemon/workload_transport_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,17 +417,38 @@ func waitRuntimeTime(t *testing.T, at time.Time) {
}

type workloadRuntimePaths struct {
connections []net.Conn
clients []*http.Client
urls []string
streams []io.ReadCloser
streamDone []<-chan error
database *pgx.Conn
label string
httpServices []string
authorityEvidence func(*testing.T)
connections []net.Conn
clients []*http.Client
urls []string
streams []io.ReadCloser
streamDone []<-chan error
database *pgx.Conn
}

func openWorkloadPaths(t *testing.T, f *privateSeparatedFixture, job *workload.Client, services map[string]string, pg *pgx.ConnConfig, label string) *workloadRuntimePaths {
t.Helper()
p := &workloadRuntimePaths{}
session, err := job.Session()
if err != nil {
t.Fatal(err)
}
p := &workloadRuntimePaths{label: label}
p.authorityEvidence = func(t *testing.T) {
t.Helper()
ctx, cancel := context.WithTimeout(t.Context(), time.Second)
defer cancel()
var revoked bool
var observed, lease, expires time.Time
if err := f.inspect.QueryRowContext(ctx, `SELECT now(),revoked_at IS NOT NULL,lease_expires_at,expires_at FROM control.workload_sessions WHERE id=$1`, session.Id).Scan(&observed, &revoked, &lease, &expires); err != nil {
t.Log("workload denial authority snapshot unavailable")
return
}
// only deadlines and revocation state: no credential, key, claims, or URL.
t.Logf("workload denial authority session=%s observed=%s revoked=%t lease_deadline=%s fixed_deadline=%s", label,
observed.UTC().Format(time.RFC3339Nano), revoked, lease.UTC().Format(time.RFC3339Nano), expires.UTC().Format(time.RFC3339Nano))
}
for _, name := range []string{"private-tcp", "private-http", "public-tcp", "public-http", "db"} {
service := services[name]
control, err := connectorstream.NewWorkloadControl(job)
Expand Down Expand Up @@ -499,6 +520,7 @@ func openWorkloadPaths(t *testing.T, f *privateSeparatedFixture, job *workload.C
client := &http.Client{Transport: tr, Timeout: 5 * time.Second, CheckRedirect: func(*http.Request, []*http.Request) error { return http.ErrUseLastResponse }}
endpoint := "https://" + net.JoinHostPort(run.Endpoint.Hostname, strconv.Itoa(run.Endpoint.Port))
p.clients, p.urls = append(p.clients, client), append(p.urls, endpoint)
p.httpServices = append(p.httpServices, name)
streamClient := *client
streamClient.Timeout = 0
response, err := streamClient.Get(endpoint + "/stream")
Expand Down Expand Up @@ -579,7 +601,8 @@ func (p *workloadRuntimePaths) denied(t *testing.T, bound time.Duration) {
if err == nil {
_ = response.Body.Close()
if response.StatusCode == 200 || response.StatusCode >= 300 && response.StatusCode < 400 {
t.Fatal("denied workload fell back to browser approval or target")
p.authorityEvidence(t)
t.Fatalf("denied workload fell back to browser approval or target: session=%s service=%s status=%d", p.label, p.httpServices[i], response.StatusCode)
}
}
}
Expand Down
Loading