Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
denial shutdown fixsigned commit the serving select could return normal shutdown before consuming the control worker's denial. separately, an error joining that denial with EOF was classified as normal EOF. shutdown now joins the worker and retains its protocol result; protocol errors take precedence over ordinary close/cancellation classification. a gated control-write regression deterministically exercises both paths. against the previous implementation through a read-only Go overlay, both cases fail with the original missing-denial result ( local qualification: complete |
|
CI finished on signed commit |
|
superseded by the replacement cutover tracked in #499 (replacement stack #491). closing this original PR at the author's request so only the replacement review remains active. the original branch, commits, reviews and failure evidence are preserved; no branch is deleted. outstanding integration and validation remain tracked in the replacement, not waived by this closure. |
What
keep native application streams and target sockets alive when a connector replaces either relay carrier. this continues the opt-in native packet path on top of #485; it does not enable production native admission.
Why
the inner QUIC connection can survive carrier loss, but closing the connector's outer session previously retired the relay's publisher registration. reconnecting needs an explicit transfer of that registration's delivery ownership while retaining its deadline and replay history.
Changes
native_leg_handoff/native_leg_handed_off, binding a fresh signed hello to the exact previous selected nonce. reject consumed predecessors, reused candidates, changed source/assignment/process, and expired authority; retain at most 64 selected candidates per bridge.bab9c4e2: routine Go/public-consumer tests, lint, full race suite, generation, committed generation check, and formatting passed. the final race integration matrix passed all ten loss cases (124.36s), claim renewal (57.35s, both claims advanced at least 30.024s), and reconnect cases (15.84s); daemon total 199.224s.assignment/source/network changes, endpoint replacement, ICE/direct upgrade, public-ingress cutover, and deployed proxy-source qualification remain separate cutover work. production native gates remain off. prior unresolved runtime/CI observations remain recorded in #485's evidence; this matrix is not a root-cause finding for those failures.