Skip to content

fix(website): improve landing page mobile view - #1548

Merged
tomalaforge merged 1 commit into
mainfrom
tomalaforge/mobile-landing-page-fixes
Aug 31, 2026
Merged

fix(website): improve landing page mobile view#1548
tomalaforge merged 1 commit into
mainfrom
tomalaforge/mobile-landing-page-fixes

Conversation

@tomalaforge

@tomalaforge tomalaforge commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • Hide the hamburger menu icon on the landing page (no sidebar exists there, so the button served no purpose on mobile)
  • Shorten sponsor banner text on mobile ("Sustained by sponsors") so the banner stays on one line; full text is preserved on larger screens

Changes

  • SiteHeader gains a showMenu input (default true) that controls visibility of the hamburger button
  • Landing page passes [showMenu]="false" to opt out of the menu button
  • Sponsor banner container switches from flex-wrap to a single-row layout with a truncating label that swaps text at the sm breakpoint

Summary by CodeRabbit

  • New Features

    • Added an option to hide the navigation menu on specific pages.
    • The landing page now displays a simplified header without the menu.
  • Style

    • Improved the sponsors banner layout for better responsiveness.
    • Sponsor messaging now adapts to screen size and avoids unwanted wrapping.

Hide hamburger menu icon on landing page (no sidebar needed) and
shorten sponsor banner text on mobile to keep it on one line.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
angular-challenges-website Ready Ready Preview Aug 31, 2026 7:35am

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 420f95ae-04e9-4b18-8398-fcca872839ae

📥 Commits

Reviewing files that changed from the base of the PR and between 0d8a8da and fe7677e.

📒 Files selected for processing (3)
  • website/src/app/layout/site-header.html
  • website/src/app/layout/site-header.ts
  • website/src/app/pages/landing/landing.html

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The site header now accepts a showMenu input. The landing page disables the menu and updates the sponsor banner for responsive text and layout behavior.

Changes

Landing page UI

Layer / File(s) Summary
Conditional header menu visibility
website/src/app/layout/site-header.ts, website/src/app/layout/site-header.html, website/src/app/pages/landing/landing.html
SiteHeader adds a default-enabled showMenu input and conditionally renders the menu toggle. The landing page sets [showMenu]="false".
Responsive sponsor banner layout
website/src/app/pages/landing/landing.html
The sponsor banner prevents wrapping, truncates its label, and displays breakpoint-specific text.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to fe767

This PR hides the unused landing-page menu button and shortens the sponsor label on small screens without changing application behavior or data flows. No actionable merge-blocking risk remains beyond normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the implementation and user-facing changes, but it omits the required challenge submission checklist, important notice, sponsorship information, and submission guidance from t… Add the required template sections and information, including the challenge submission checklist, the sponsorship notice, the pricing details, the GitHub Sponsors link, and the community submission guidance. Also update the PR title to star…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: improving the website landing page mobile view. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the implementation and user-facing changes, but it omits the required challenge submission checklist, important notice, sponsorship information, and submission guidance from the repository template.

Resolution

Add the required template sections and information, including the challenge submission checklist, the sponsorship notice, the pricing details, the GitHub Sponsors link, and the community submission guidance. Also update the PR title to start with Answer:${challenge_number} as required by the template.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tomalaforge/mobile-landing-page-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tomalaforge
tomalaforge merged commit cd75086 into main Aug 31, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant