Skip to content

chore: remove confirmed dead i18n keys (r68 wave, 18 keys) - #4329

Open
topcheer wants to merge 1 commit into
mainfrom
chore/deadcode-r68
Open

topcheer wants to merge 1 commit into
mainfrom
chore/deadcode-r68

Conversation

@topcheer

Copy link
Copy Markdown
Owner

r68 dead-code wave — 18 catalog-only i18n keys, 360 deletions across 10 language catalogs.

Methodology

Removed

Group Keys
panel titles ×8 conversation, composer, composer_locked, context, metrics, mode_policy, agent_status, startup
provider panel.provider.api_key (bare; .missing/.configured/edit./new_vendor. stay live)
panel.qq ×5 bind_channel, entry.bound, qr_code, scan_hint, share_link
update restart_failed
command ×3 mention_error, usage.export, usage.resume

Kept as live (verified)

  • update.pm_hint.{brew,scoop,winget,snap} — dynamic key update.pm_hint.+pm at update.go:140; PackageManagerHint domain exactly {brew,scoop,winget,snap} (detect.go:260-291)
  • interrupted — dotless key, live via m.t at model_pending.go:192
  • provider.api_key.missing/.configured, edit.vendor_api_key/endpoint_api_key, new_vendor.step_api_key — live in provider_panel.go

Validation

  • go build -tags goolm ./… ✅ (GOFLAGS=-p=1 GOMEMLIMIT=2GiB)
  • go vet -tags goolm ✅
  • full ./internal/tui/ test suite ✅ (includes i18n completeness parity)

Remove 18 catalog-only keys with zero non-catalog references,
verified via full-repo exact-quote grep + dynamic-prefix whitelist,
and confirmed absent from all five in-flight deadcode waves
(r61/r64/r65/r66/r67):

- panel titles x8: conversation, composer, composer_locked, context,
  metrics, mode_policy, agent_status, startup
- panel.provider.api_key (bare key; api_key.missing/.configured and
  edit/new_vendor variants remain live)
- panel.qq x5: bind_channel, entry.bound, qr_code, scan_hint,
  share_link (r64 owns a disjoint set of 4 other qq keys)
- update.restart_failed
- command x3: mention_error, usage.export, usage.resume

Excluded as live: update.pm_hint.{brew,scoop,winget,snap} (dynamic
key, PackageManagerHint domain closed), "interrupted" (dotless key
used via m.t in model_pending.go), all tool.* (dynamic "tool.%s").

360 deletions across 10 language catalogs; build/vet/tui tests green
(-tags goolm).

Co-Authored-By: ggcode <noreply@ggcode.dev>
@topcheer

Copy link
Copy Markdown
Owner Author

[ggcxf 走读] GO:18 死键(panel./command./update.* 族,含 panel.qq 5 子键+command.usage 2 子键)×10 语言目录对称移除,+0/-360 纯删除(每键 10 目录×2 行=20,360/18=20 恰合),抽样计数与标题 18 键自洽,无逻辑面(#4317/#4325/#4327 同族 r68 wave)。门面:CI Test=pending;approvals=0(ggaidev=read 通道断损同根因)。CI 绿+审批在案后进合并判定。

@topcheer

Copy link
Copy Markdown
Owner Author

[ggcxf 更新] CI 已全绿(9/9,Test=pass)。走读 GO 在案,仅剩审批面阻塞(approvals=0,ggaidev=read 通道未修复),留治理处置。

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant