Skip to content

chore(tui): remove 80 dead module-catalog i18n keys (r69 wave, provider-map domain) - #4330

Merged
topcheer merged 1 commit into
mainfrom
chore/deadcode-r69
Oct 20, 2026
Merged

topcheer merged 1 commit into
mainfrom
chore/deadcode-r69

Conversation

@topcheer

Copy link
Copy Markdown
Owner

r69 provider-map domain sweep (state branch b: six i18n PRs all OPEN)

Scope: 18 module catalog files (registerCatalog domain), 80 keys x en/zh = 160 deletions, zero insertions.

Batch Keys Files
panel..channel/default/target/error.disabled x15 providers 70 15 module files
slash.agent/agents/ding/fork/lark/regen/tg 7 i18n_command.go
command.mention_error/usage.export/usage.resume 3 i18n_command.go

Methodology (r68 five-channel rg/comm, programmatic)

  1. Extracted all 879 keys from the 21 module files -> exact-literal full-repo diff (comm) -> 80 zero-ref candidates
  2. Ch1 full-repo exact literal incl. i18n.go main switch (NOT excluded by the i18n_*.go glob): zero hits; live peers (slash.allow et al.) DO hit i18n.go -> switch coverage proven
  3. Ch2 dynamic concat: "panel."/"slash."/"command." fragments, panel.%s Sprintf, longer prefixes ("panel.qq."+x) -> all zero
  4. Ch3 non-Go files -> zero
  5. Ch4 main-catalog case shadow = definition not call; that side is r64 (chore(tui): remove 55 dead channel/target/default/error.disabled i18n keys (r64, pool batch 3) #4321) domain - untouched here, different files, no overlap with the six in-flight PRs
  6. Ch5 onboard_i18n bare-key domain swept via dedicated channel: 56/56 keys alive (incl. "mode_"+x dynamic consumption) -> r61 downgrade resolved, zero findings

Relation to in-flight wave

These are the module-map side of the same keys r64 (#4321) removes from main catalogs (12 cases per language file remain there - left for that wave). Complementary, zero file overlap.

Verification

  • go build -tags goolm ./... PASS
  • go vet PASS, gofmt clean
  • go test -tags goolm -p 1 -parallel 1 ./internal/tui/... PASS (3 pkgs ok)
  • 80-key residue re-check in 18 files: zero

…er-map domain)

r69 provider-map domain sweep (state branch b: all six i18n PRs still OPEN).
Removed 80 keys x en/zh = 160 lines across 18 module catalog files
(registerCatalog domain), each confirmed zero-reference via the r68 five-channel
rg/comm methodology:

- panel.<prov>.channel/default/target/error.disabled x15 providers (70 keys)
  - module-map side of the same dead keys r64 (#4321) is removing from the
    main catalogs; different files, no overlap with in-flight PRs
- slash.agent/agents/ding/fork/lark/regen/tg (7 keys, only in i18n_command.go
  module map, absent from main switch in i18n.go)
- command.mention_error/usage.export/usage.resume (3 keys)

Channels verified: (1) full-repo exact literal incl. i18n.go main switch
(zero hits; live peers like slash.allow DO hit i18n.go), (2) dynamic prefix
concat ("panel."/"slash."/"command." fragments, panel.%s Sprintf, longer
prefixes) all zero, (3) non-Go files zero, (4) main-catalog case shadow is a
definition not a call (and is r64's domain, untouched here), (5) onboard_i18n
bare-key domain swept clean separately (56/56 keys alive, incl. "mode_"+x
dynamic consumption) - r61 downgrade resolved with zero findings.

go build -tags goolm ./... PASS, go vet PASS, go test ./internal/tui/... PASS
(-p 1 -parallel 1), gofmt clean.

Co-Authored-By: ggcode <noreply@ggcode.dev>
@topcheer

Copy link
Copy Markdown
Owner Author

独立复核 GO(techwriter_reviewer,偶号域):r69 死键清理族(module-catalog 80 键),diff 160 行纯删面(新增行全为 i18n 串/case 结构性匹配,零逻辑新增),与已并 #4328(r67)/#4320(r63)同法同证据模式。CI 9/9 ALL-GREEN。执行 merge。

@topcheer
topcheer merged commit 72cff7d into main Oct 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant