Repository navigation
Conversation
New-wave symbols surfaced by r80 fresh scan vs r79 baseline (all double-mode unreachable: deadcode + deadcode -test, zero repo refs): - agent_tool.go: simStripAllLineNumberPrefixes (11 lines; sibling sim* helpers keep 3 other callers - no orphan cascade) - model_cascade.go: Agent.cascadeTurnProvider (comment claimed "exposed for tests" but no test references it; provider import dropped with it) - tool_fallback_hints.go: isEmptyToolResult (superseded by isZeroMatchSuccess per #3673; only comment mentions remain, kept) agentruntime domain (50 hits, first single-listed scan): ALL reachable in -test mode (test-kept) - deferred per methodology, none touched. Verified: go build -tags goolm ./... OK; go vet ./internal/agent/ OK; go test ./internal/agent/ OK (38s); post-scan = 1004 lines, diff vs r79-after baseline IDENTICAL, zero new orphans. Co-Authored-By: ggcode <noreply@ggcode.dev>
Owner
Author
|
Duplicate of #4343 (deadcode r79, same 3 symbols: cascadeTurnProvider/isEmptyToolResult/simStripAllLineNumberPrefixes, identical file set). Root cause: r80 scan misread the r79-after baseline (post-cleanup worktree state, 1004) vs fresh main scan (1007) — the +3 delta was r79's own unmerged deletions, not a new wave. Keeping first PR #4343; closing this one. agentruntime domain result (50 hits all test-alive, correctly pooled) unaffected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r80 dead-code scan (state-branched: no new merges in pool -> fresh-diff-first, then agentruntime domain)
New wave (r80 fresh vs r79-after: +3 hits, all internal/agent, all double-mode unreachable via
deadcode+deadcode -test, zero repo refs by grep):simStripAllLineNumberPrefixesAgent.cascadeTurnProviderproviderimport dropped with itisEmptyToolResultisZeroMatchSuccess(#3673); comment mentions kept (issue-history records)agentruntime domain (50 hits, first single-listed): ALL reachable in
-testmode (test-kept) -> deferred per methodology, zero files touched.Verification:
go build -tags goolm ./...OKgo vet -tags goolm ./internal/agent/OKgo test -tags goolm ./internal/agent/OK (38s)Pool status checked: #4317/#4321/#4325/#4327/#4329/#4331/#4333/#4337/#4343 all OPEN, none touch agentruntime files.