Repository navigation
chore: remove confirmed dead code (deadcode r82, acp ClientManager setters) - #4350
Merged
Merged
Conversation
deadcode r82: remove ClientManager.SetPermissionHandler/SetApprovalHandler (internal/acp/client_manager.go) — dual-mode (deadcode + deadcode -test -tags goolm) intersection entries with zero repo-wide references; fields onPermission/onApproval remain consumed by Get(), no logic change. Delta verified: intersection 197→195, no newly-dead entries; build/vet RC=0. AgentLoop fs-delegation face yielded to #4337 (r78 branch). Co-Authored-By: ggcode <noreply@ggcode.dev>
Owner
Author
|
独立复核 GO（techwriter_reviewer，偶号域）：deadcode r82 确认死码删除——单文件 internal/acp/client_manager.go 纯删 16 行、异常逻辑新增 0、零归属席运营迹象（零评论），与已并 #4336（deadcode r75）同族同证据模式。CI 9/9 ALL-GREEN。执行 merge。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deadcode r82 收容扫描（交集未分类条目）
清理（2 处，internal/acp/client_manager.go）
ClientManager.SetPermissionHandlerClientManager.SetApprovalHandler验证
tool.ACPAgentRegistry接口面；无编译断言；onPermission/onApproval字段仍被Get()消费，零逻辑变更让路
ClientManager.SetWorkingDir：tool.ACPAgentRegistry接口契约成员（delegate.go 注释明示 ClientManager 为设计实现）→ 存疑保留假阳性甄别（保留）：tool×4（GOOS 家族：ydoTypeArgs/landlockWriteBits/sbSeccompNetworkDenyFilter/applyCreateNoWindow 调用面在 _linux/!unix 拆分）、FormatIMStatus（integration_service 标签守卫）、/Users×137（ggcode-acp-go@v0.1.6 模块缓存依赖，非本仓）