Repository navigation
chore: remove confirmed dead code (r85) - #4360
Merged
Merged
Conversation
Remove adhocEnvTouched (cmd/ggcode/adhoc.go) — unreachable from any main entrypoint and zero references repo-wide incl. tests (verified via deadcode -tags goolm + repo-wide grep dual-check, round 85).
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dead-code sweep round 85 (user-directed; worktree fresh-main @ 3bf5b39).
Removed (1 item — 100% confirmed):
adhocEnvTouched(cmd/ggcode/adhoc.go, 11 lines incl. doc comment): unreachable from any entrypoint (deadcode -tags goolm), zero references repo-wide incl. tests (grep dual-check). Referenced adhocEnv* constants stay (used by synthesizeAdhocConfig).Verified: go build -tags goolm ./... ✅ · go vet -tags goolm ./cmd/ggcode/... ✅ · gofmt clean.
Not touched (protected): 6 uncommitted main-tree files; pool file-scopes (#4317/#4321/#4325/#4327/#4329 tui i18n, #4333 mcp/elicitation, #4337 acp/agent_loop, #4343 agent 3 files, #4351 a2a+tool 4 groups); r84 frozen surfaces (wailskit dead component, api_keys, agent check family, acp/client 68 — #4337 still OPEN).
Cross-wave rescan: r84→r85 deadcode symbol sets identical (sort-diff=0); merges #4354/#4347/#4339 introduced zero new dead code / zero orphans.