Skip to content

feat(api): accept notes on list item adds - #1051

Merged
StefanFriptu merged 4 commits into
masterfrom
feat/list-item-add-notes
Oct 30, 2026
Merged

StefanFriptu merged 4 commits into
masterfrom
feat/list-item-add-notes

Conversation

@StefanFriptu

Copy link
Copy Markdown
Collaborator

List, watchlist, collection and history request bodies now match what the API accepts.

  • Notes: list and watchlist adds accept notes per item.
  • History: watched_at accepts released, unknown and now. Movies and shows can be sent by title alone.
  • Episode ids: tmdb and imdb are accepted.
  • No watched_at on list, watchlist and collection bodies, which never used it.

Breaking for typed clients only: passing watched_at to those bodies is now a type error, and not_found items may lack ids.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T17:37:49.305461Z 38f807d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38f807d1b2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@StefanFriptu
StefanFriptu force-pushed the feat/list-item-add-notes branch from 38f807d to 4e57ab0 Compare October 30, 2026 17:50
…dies

History and hidden bodies now take the same item identity as list
items: ids, title and year are each optional, and a season's episodes
may be left out. watched_at takes a UTC datetime or one of released,
unknown and now.

The not_found response shapes loosen with it: history, history remove
and hidden echo the history items, and list, watchlist and collection
echo the base items without watched_at. TypeScript consumers that
narrowed the old ids-or-title union on not_found items must null-check
ids instead.
@StefanFriptu
StefanFriptu force-pushed the feat/list-item-add-notes branch from 4e57ab0 to ef46c50 Compare October 30, 2026 18:02
@StefanFriptu
StefanFriptu merged commit 3f7ea1a into master Oct 30, 2026
9 checks passed
@StefanFriptu
StefanFriptu deleted the feat/list-item-add-notes branch October 30, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant