Repository navigation
fix(api): type the sync collection add and remove contracts - #1058
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
StefanFriptu
force-pushed
the
fix/sync-collection-contract
branch
from
November 3, 2026 16:11
660333c to
9154bfa
Compare
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /sync/collectionandPOST /sync/collection/removereused the list item body and the list add/remove responses, so the SDK had nocollected_ator metadata fields on the request and typed alistobject,shows/seasonscounts and noupdatedon the response.Add now takes
collected_at(UTC datetime,released,unknownornow),media_type,resolution,hdr,audio,audio_channelsand3don every item level, and returnsadded,updatedandexistingas{ movies, episodes }plusnot_found. Remove keeps the plain item body and returnsdeletedas{ movies, episodes }plusnot_found. New exported types:CollectionAddRequest,CollectionAddResponse,CollectionRemoveResponse.Clients can call the routes today with the old types; the new fields need the next publish.
Checked with
bun run check,bun run test,bun run publish:check,bun run openapi:validate, and a.strict()parse probe of every add/remove response case.