Fix multi-day ICS downloads dropping location fields - #206
Merged
Merged
Conversation
Document the actual 6.x LOCATION/URL/GEO/DESCRIPTION resolution in one table and cross-reference it from events:download_link.
1 task
Share decorate() across event types and guard coordinates so whole-event downloads keep LOCATION/URL/DESCRIPTION/GEO.
Subclasses build the bare event; only the base toICalendarEvent path applies location fields.
edalzell
force-pushed
the
fix/multi-day-ics-missing-fields
branch
from
September 8, 2026 22:56
5e2f0ba to
278c8d4
Compare
Member
Author
|
Updated: decorate() now only runs inside base toICalendarEvent(). Subclasses override buildICalendarEvent() / call toICalendarEvent() from toICalendarEvents() instead of decorating at every call site. Also retargeted this PR onto fix/reconcile-ics-field-docs (#205) so the 6.x work stays stacked. We'll forward-merge to main once the 6.x stack is done (#207 closed). |
Use the same null-check and single-element array form as RecurringEvent.
Entry::get() is untyped; mixed avoids a TypeError on the public ICS route.
This was referenced Sep 9, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decorate()for address/coordinates/description/url onto the base Event typeCloses #192
Part of #190
Test plan
vendor/bin/pest --filter=IcsControllerTestdateparam and confirm LOCATION/URL/DESCRIPTION/GEO appear for each day?date=downloads still include those fields