Skip to content

Add online_url for Zoom and livestream links - #209

Merged
edalzell merged 2 commits into
6.xfrom
feature/online-url
Sep 9, 2026
Merged

edalzell merged 2 commits into
6.xfrom
feature/online-url

Conversation

@edalzell

@edalzell edalzell commented Sep 9, 2026

Copy link
Copy Markdown
Member

Summary

Non-breaking / additive — targets 6.x so current sites can use join links without waiting for 7.0.

Closes #193
Part of #190

Test plan

  • vendor/bin/pest --filter=IcsControllerTest
  • Create an event with only online_url and confirm ICS has URL:
  • With both online_url and link, confirm online_url wins
  • Confirm existing link / URL-location behaviour still works

Prefer online_url for ICS URL while keeping deprecated link and URL-valued location fallbacks.
Renaming a protected method would break subclasses; defer any rename to 7.0.
@edalzell

edalzell commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

Follow-up: kept the protected method named `eventUrl()` instead of renaming to `icsUrl()`. Renaming a protected method is a breaking change for subclasses, so that waits for 7.0 (#195). Plan updated on #190 / #193.

@cursor

cursor Bot commented Sep 9, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@edalzell
edalzell merged commit e1c62e2 into 6.x Sep 9, 2026
25 checks passed
@edalzell
edalzell deleted the feature/online-url branch September 9, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant