Serve Front dist zips from Satis - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist.tar.gzfrom a private GitHub release URL. After Front moved behind Satis, that 401s because site Composer auth ispkgs.trns.fm, not GitHub.extra.download-distathttps://pkgs.trns.fm/assets/front/{$version}/dist.tar.gz(sibling of Satis’s ownpublic/distarchives).Server (not in this PR)
satis build, shouldgh release downloaddist.tar.gzinto/home/forge/pkgs.trns.fm/public/assets/front/<tag>/.ghreads~/.config/gh/hosts.yml(PAT withcontents:readon every Satis GitHub repo). Deploy keys cannot download release assets./assets/(cat /etc/nginx/forge-conf/3287057/server/*— not the site home). If the security rule is only/dist/, extend it or the zip is public.Test plan
dist.tar.gzassethttps://pkgs.trns.fm/assets/front/v3.2.0/dist.tar.gzis 401 without creds, 200 with Satis http-basiccomposer update transformstudios/fronton a site populatesvendor/transformstudios/front/dist/