Rebuild Satis after the release publishes - #29
Merged
Merged
Conversation
edalzell
changed the title
edalzell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release: published, but the publish step usesGITHUB_TOKENand GitHub does not start workflows from events that token creates. So a release never rebuilt Satis, and the new version'sdist.tar.gznever got mirrored topkgs.trns.fm.needs: publish, so the rebuild runs after the asset is attached.A push-based trigger like Prime's would fire at merge time, before
upload_assetsfinishes building and uploading, so the new tag would be skipped until some later rebuild. Prime has no assets, so it does not hit that.Test plan
release/*PR and confirm Satis runs after Release Publish