Repository navigation
Support custom cursors in the web backend - #203
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning
CustomCursoron Emscripten previously reset the browser cursor toauto. Encode the supplied image as a PNG data URL and apply its hotspot through the canvas CSS cursor property. A nil image keeps the default cursor, and image encoding failures are reported asWindyError.Use Pixie's existing
encodeImage(PngFormat)API with standard base64 encoding so the change remains compatible with the pinned Pixie 5.1.0 dependency. The string passed to JavaScript now uses an explicitcstringconversion.Validation:
nim check --threads:off -d:emscripten examples/custom_cursor.nimpassed.nim c --threads:off -d:emscripten examples/custom_cursor.nimpassed with Nim 2.2.10 and Emscripten 6.0.1.(0, 0), one left click switches toauto, and the second restores the custom cursor. No browser warnings or errors.git diff --checkpassed.