feat: Integrate workflow checks with GitHub PR checks - #502
Merged
Merged
Conversation
Ziinc
marked this pull request as ready for review
September 23, 2026 18:01
Ziinc
changed the title
Co-authored-by: ty <ty@tzeyiing.com>
Co-authored-by: ty <ty@tzeyiing.com>
Co-authored-by: ty <ty@tzeyiing.com>
…oval - reformat ChecksTab.tsx to satisfy biome - drop unused LogsBrowser component and its now-orphaned getRunLogs/exportRunLogs API wrappers and Tauri command, since log inspection moved to the standalone Logs tab - delete checks.test.tsx, which exercised the standalone workspace Checks tab UI that this PR removes - update logs-tab.test.tsx to seed workflow runs via the runWorkflow API instead of the removed Checks tab, matching the updated screenshot spec Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HGag9hHCkQDtTCf5QVBckx
Ziinc
force-pushed
the
cursor/integrate-pr-checks-542e
branch
from
September 24, 2026 14:11
31d3d42 to
f5fb08a
Compare
- run cargo fmt to drop the trailing blank line left by the earlier export_run_logs removal - the PR's own diff drops the `!workspace &&` guard on the Logs tab, so it's intentionally offered inside a workspace now; update the test that still asserted the old, now-contradicted behavior Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HGag9hHCkQDtTCf5QVBckx
Ziinc
pushed a commit
that referenced
this pull request
Sep 27, 2026
- ci-status-indicator: spread the real features module in the mock so PREVIEW_FEATURE_IDS (added since) is defined. - cmdk-github-pr-workspace-open: the no-PR case used a mock renamed to mockGetCachedPrInfo. - checks-tab: the workspace Checks tab was removed in #502; drive the checks panel in its new home, the Treq checks section of a PR's detail pane, and trim captures to the 3-expectation limit. - prompt-from-github-issue: the sidebar item is labeled "Github". - create-pr-combined-push: wait for the changed file to list before typing the commit message; the commit form remounts once changes load, which dropped the typed message and left Create PR disabled.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run checkpasseschecks-logs-01-run-history.pngnpm run lintremains blocked by a pre-existing user-event setup rule intest/integration/sidebar-branch-switch-click-lock.test.tsx