test: Give the reviews mark-viewed test a 15s budget - #536
Merged
Merged
Conversation
"is able to mark a file as viewed and back to unviewed" sets up a repo and workspace, renders the Dashboard and does two Viewed round trips through the Rust backend inside the 5s default testTimeout. Under CPU contention (CI runners, or a local run beside another suite) it intermittently runs past 5s, failing unrelated PRs, and fails the same way on main. Match the explicit 15s budget the other heavy Dashboard integration tests use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test/integration/workspace/reviews.test.tsx > is able to mark a file as viewed and back to unviewedfails intermittently withTest timed out in 5000ms. It failed CI on #521, a PR that does not touch that code path.testTimeout(vitest.integration.base.ts).main: 2 of 5 local runs while another suite was running.Fix
Give the test an explicit
15_000budget, the same as the other heavy Dashboard integration tests (for exampleremote-workspace-ui.test.tsx).Verification
With every core busy, the file failed 1 of 4 runs before this change and passed 6 of 6 after it; the viewed test took 2.0–2.8s.
lintandformatare clean.Generated by Claude Code