-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(webapp): unconfigured billing limit UX and default billing alerts #4328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kathiekiwi
wants to merge
12
commits into
main
Choose a base branch
from
feature/default-billing-alerts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1a60059
feat(webapp): unconfigured billing limit UX and default billing alerts
kathiekiwi 92d1ae4
fix(webapp): hide no-billing-limit banner for users without billing p…
kathiekiwi 8862678
feat(webapp): seed default billing alerts on organization creation
kathiekiwi a8b80cc
chore(webapp): drop billing alerts backfill machinery in favor of bil…
kathiekiwi 4b5fe49
test(webapp): cover unselected billing limit mode and default alerts
kathiekiwi f127eac
fix(webapp): await default billing alerts seed to avoid racing user e…
kathiekiwi 0e305e5
chore: revert unrelated llm-model-catalog churn
kathiekiwi 66e18f9
fix(webapp): preview percentage billing alerts against the current limit
kathiekiwi d20df98
chore: merge server-changes notes into one
kathiekiwi 42bc4b8
chore(webapp): tighten comments
kathiekiwi 27cb1f0
fix(webapp): import tryCatch from core subpath
kathiekiwi c478e72
fix(webapp): cap default alerts seed with a 5s timeout
kathiekiwi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| area: webapp | ||
| type: improvement | ||
| --- | ||
|
|
||
| Organizations without billing alerts now get default spend alert thresholds, so you're notified before usage grows unexpectedly. The billing limit page no longer pre-selects an option before you've set a limit and prompts you to configure one. Alert previews now update immediately after you change your billing limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import type { UpdateBillingAlertsRequest } from "@trigger.dev/platform"; | ||
| import { ABSOLUTE_ALERT_BASE_CENTS } from "~/components/billing/billingAlertsFormat"; | ||
|
|
||
| /** Default absolute alert thresholds in dollars. */ | ||
| const DEFAULT_ALERT_THRESHOLD_DOLLARS = [5, 100, 500, 1000, 2500]; | ||
|
|
||
| /** | ||
| * Alerts fire at `usage / amount >= level`; amount = 100 cents makes levels | ||
| * absolute dollar thresholds. Empty emails fall back to org admins. | ||
| */ | ||
| export function buildDefaultBillingAlerts(): UpdateBillingAlertsRequest { | ||
| return { | ||
| amount: ABSOLUTE_ALERT_BASE_CENTS, | ||
| emails: [], | ||
| alertLevels: [...DEFAULT_ALERT_THRESHOLD_DOLLARS], | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
| import { buildDefaultBillingAlerts } from "~/services/billingAlertsDefaults.server"; | ||
| import { ABSOLUTE_ALERT_BASE_CENTS } from "~/components/billing/billingAlertsFormat"; | ||
|
|
||
| describe("buildDefaultBillingAlerts", () => { | ||
| it("uses the absolute dollar base so alert levels read as dollar thresholds", () => { | ||
| expect(buildDefaultBillingAlerts().amount).toBe(ABSOLUTE_ALERT_BASE_CENTS); | ||
| expect(buildDefaultBillingAlerts().amount).toBe(100); | ||
| }); | ||
|
|
||
| it("starts with no recipients so the platform falls back to org members", () => { | ||
| expect(buildDefaultBillingAlerts().emails).toEqual([]); | ||
| }); | ||
|
|
||
| it("seeds the default dollar alert thresholds", () => { | ||
| expect(buildDefaultBillingAlerts().alertLevels).toEqual([5, 100, 500, 1000, 2500]); | ||
| }); | ||
|
|
||
| it("returns a fresh alertLevels array each call (no shared mutable state)", () => { | ||
| const first = buildDefaultBillingAlerts(); | ||
| const second = buildDefaultBillingAlerts(); | ||
| expect(first.alertLevels).not.toBe(second.alertLevels); | ||
| first.alertLevels.push(9999); | ||
| expect(second.alertLevels).toEqual([5, 100, 500, 1000, 2500]); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.