Repository navigation
docs: Add SECURITY.md - #20
Conversation
TRI-1935
|
TRI-1935
|
|
||
| ## Critical Security Assumptions | ||
|
|
||
| * The component is deployed in a trusted environment or behind a gateway that provides authentication, authorization, TLS and rate limiting. |
There was a problem hiding this comment.
Shared cache lacks tenant isolation If mutually distrusting tenants share one cache instance and the host supplies the same key for their requests, gateway authentication does not separate their entries. The cache looks up responses using only that key, so one tenant can receive another tenant’s cached response. The security assumptions should state that tenants need separate cache instances or tenant-scoped keys. How this was verified: Lookup reads from one shared map using the caller-supplied key, with no tenant check.
| * The component is deployed in a trusted environment or behind a gateway that provides authentication, authorization, TLS and rate limiting. | ||
| * Models, configuration and other inputs come from trusted sources. | ||
| * Dependencies and the build environment are kept up to date and obtained from trusted sources. | ||
| * Operators protect secrets, certificates and credentials, and restrict access to logs and metrics. |
There was a problem hiding this comment.
Plaintext memory exposure omitted The replacement guidance covers logs and metrics but no longer tells operators that cached responses remain readable in process memory, including after eviction. This can lead operators handling sensitive responses to overlook exposure through a memory dump or other code in the process. How this was verified: Responses occupy a plain allocated buffer, and eviction deallocates their regions without clearing the bytes.
|
|
||
| NVIDIA is dedicated to the security and trust of our software products and services, including all source code repositories managed through our organization. | ||
|
|
||
| If you need to report a security issue, please use the appropriate contact points outlined below. **Please do not report security vulnerabilities through GitHub/GitLab.** If a potential security issue is inadvertently reported via a public issue or pull request, NVIDIA maintainers may limit public discussion and redirect the reporter to the appropriate private disclosure channels. |
There was a problem hiding this comment.
Deployment safeguards no longer documented If this cache is used with a network-facing Triton server, the replacement removes this repository’s only guidance that authentication, authorization, TLS, and rate limiting must be provided outside the cache. Operators relying on this documentation may miss those safeguards. If SECURITY.md must remain the standard reporting template, preserve the deployment guidance elsewhere.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
What does the PR do?
SECURITY.md, which this repository did not have. Flagged by an AIVO asset review.NVIDIA/NeMo,cuda-pythonandMegatron-LM. Text is NVIDIA-authored, unmodified except the platform-neutral "GitHub/GitLab" wording fromcuda-python.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
SECURITY.md— compare againstNVIDIA/NeMo/SECURITY.mdfor the canonical wording.Test plan:
Documentation only; no code paths affected.
CI Pipeline ID:
Caveats:
NVIDIA/NeMosays "through GitHub",NVIDIA/cuda-pythonsays "through GitHub/GitLab". This PR uses the latter because Triton repositories exist on both GitHub and internal GitLab.Background
An AIVO asset review (securityportal.nvidia.com/aivo/assets) flagged Triton repositories with no SECURITY.md. Rather than authoring per-repository security documentation, every repository adopts NVIDIA's current standard template so the policy is identical everywhere and carries no repository-specific claims to maintain.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)