Skip to content

Fix sandbox artifact downloads - #493

Merged
chiragjn merged 2 commits into
truefoundry:mainfrom
gitUrLifeTogether:hackathon-sandbox-downloads
Aug 31, 2026
Merged

Fix sandbox artifact downloads#493
chiragjn merged 2 commits into
truefoundry:mainfrom
gitUrLifeTogether:hackathon-sandbox-downloads

Conversation

@gitUrLifeTogether

@gitUrLifeTogether gitUrLifeTogether commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Fix sandbox artifact downloads by:

  • guiding generated artifacts to /tmp paths
  • binding the development server to 0.0.0.0 for container access

Note

Low Risk
Sandbox prompt/download path guidance and dev-server bind address only; no auth or persistence changes.

Overview
Fixes sandbox artifact downloads when the agent runs in a container by steering user-downloadable outputs toward /tmp paths (so paths in sandbox_artifacts match what the download API can read) and binding the development server to 0.0.0.0 so in-sandbox traffic can reach the host API.

Together these address broken downloads where artifacts lived outside the resolvable filesystem or the dev server only listened on localhost.

Reviewed by Cursor Bugbot for commit 08a698e. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 08a698e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cdbccd7. Configure here.

Comment thread packages/trueforge-core/src/core/sandbox/Sandbox.ts Outdated
Comment thread packages/trueforge-core/src/core/sandbox/Sandbox.ts Outdated
@chiragjn

Copy link
Copy Markdown
Member

@gitUrLifeTogether before I review this PR, can you please explain the issue - in which scenario is file download not working for you?

Comment thread docker-compose.yml Outdated
@chiragjn
chiragjn force-pushed the hackathon-sandbox-downloads branch from cdbccd7 to c729e8b Compare August 31, 2026 19:08
@chiragjn
chiragjn force-pushed the hackathon-sandbox-downloads branch from c729e8b to 08a698e Compare August 31, 2026 19:09
@chiragjn
chiragjn merged commit 06f390c into truefoundry:main Aug 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants