Conversation
innoavator
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998,
sr07asthana and
thesujai
as code owners
August 31, 2026 19:41
|
chiragjn
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Low Risk
Docker dev build ordering and artifact copy only; no application logic or runtime behavior changes beyond fixing a broken image build.
Overview
Fixes dev Docker image builds when
@truefoundry/trueforgedepends on the workspace@truefoundry/trueforge-sdk(e.g. schedule dispatch).The builder stage now copies
packages/trueforge-sdk, runspnpm --filter @truefoundry/trueforge-sdk buildbefore compiling trueforge-core and the server, with a comment documenting that ordering requirement.The runner stage now includes the built SDK (
package.json+dist) alongside trueforge-core so productionnode_modulessymlinks resolve at runtime.Reviewed by Cursor Bugbot for commit 7f1bf52. Bugbot is set up for automated code reviews on this repo. Configure here.