Repository navigation
Feat/nav agent tools groups - #2
Merged
Merged
Conversation
✅ Deploy Preview for amplify-bar ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟡 Changes recommended
The Amplitude effect submits unfinished group edits on every keystroke, creating unintended properties and intermediate memberships instead of applying drafts only through an explicit action.
1 open issue
What changed in this PR
Adds group-targeting controls and an agent callback tool to the dashboard’s SDK configuration panel.
Changes:
- Persists group type, name, property, and value inputs and connects them to Amplitude group APIs.
- Registers a client-side callback tool for agent invocation.
- Selects the analytics staging endpoint using the active API environment.
| File | Description |
|---|---|
src/utils/localStorage.js |
Adds storage keys and accessors for group settings. |
src/layout/Dashboard/Drawer/DrawerContent/NavCard.jsx |
Adds group controls, group API calls, callback registration, and corrected endpoint selection. |
Review effort: Balanced
Comment on lines
+126
to
+129
| if (groupType && groupName) { | ||
| amplitude.setGroup(groupType, groupName); | ||
| if (groupProperty) { | ||
| amplitude.groupIdentify(groupType, groupName, new amplitude.Identify().set(groupProperty, groupPropertyValue)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.